Register for the iXsystems Community to get an ad-free experience and exclusive discounts in our eBay Store.

freenas-common file, add_port stupid question

Status
Not open for further replies.

joeschmuck

Old Man
Moderator
Joined
May 28, 2011
Messages
8,257
So while looking at the freenas-common file under the trunk/nanobsd directory, I have seen for a long time stuff like this:

Code:
#+add_port www/lighttpd
add_port www/spawn-fcgi
#-add_port www/lighttpd
add_port www/lighttpd
fi
add_port www/nginx
#+add_port www/py-flup
#-add_port www/py-flup
add_port www/py-flup
#+add_port sysutils/nut
#-add_port sysutils/nut


You see the #+add_port and #-add_port statements. Is there any significance to these or are they simply just commented out and meant as notes to the programmer?

Thanks.
 

ProtoSD

FreeNAS Guru
Joined
Jul 1, 2011
Messages
3,353
I've wondered the same thing myself, but I think they mark the beginning and end of a group of ports/dependencies, or a certain order to build them?

If anyone knows for sure, I'd like to know also.
 

joeschmuck

Old Man
Moderator
Joined
May 28, 2011
Messages
8,257
I was going to try a build without all these comments but with my luck I'd cause some major issue and I'd loose all my data, kind of like using 'dd' :)
 

gcooper

FreeNAS Experienced
Joined
Sep 23, 2011
Messages
416
So while looking at the freenas-common file under the trunk/nanobsd directory, I have seen for a long time stuff like this:

Code:
#+add_port www/lighttpd
add_port www/spawn-fcgi
#-add_port www/lighttpd
add_port www/lighttpd
fi
add_port www/nginx
#+add_port www/py-flup
#-add_port www/py-flup
add_port www/py-flup
#+add_port sysutils/nut
#-add_port sysutils/nut


You see the #+add_port and #-add_port statements. Is there any significance to these or are they simply just commented out and meant as notes to the programmer?

Thanks.
They're just there for the sake of documentation. Eventually I want a tool that lists just the packages we care about, omit all of the dependencies, etc to remove the majority of the noise in this file, and finally drive all of the needed knobs via make.conf (WITHOUT_X11=y, etc).

That's probably going to go in sometime 6-9 months from now.
 

joeschmuck

Old Man
Moderator
Joined
May 28, 2011
Messages
8,257
Thanks. I'd just like to clean-up what I'm currently using and although I know the "#" means to comment it out, you never know when it will have a different meaning somewhere else.
 
Status
Not open for further replies.
Top